Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: if no component set to match against, skip checking server response #1311

Merged
merged 1 commit into from
May 14, 2024

Conversation

WillieRuemmele
Copy link
Member

What does this PR do?

if we don't have a component set, skip checking it against the server response
everything surrounding the method was on an iteration of the component set, this wasn't

What issues does this PR fix or reference?

forcedotcom/cli#2862, @W-15735078@

Functionality Before

doing a metadata deply/project report would result in incorrect warnings

Functionality After

no incorrect warnings

@WillieRuemmele WillieRuemmele requested a review from a team as a code owner May 13, 2024 17:32
@cristiand391
Copy link
Member

QA notes:

setup:

  1. create dreamhouse scratch org
  2. convert project to mdapi: sf project convert source --source-dir force-app --output-dir mdapi
  3. async, dry-run deploy: sf project deploy start --dry-run --metadata-dir mdapi --async
  4. get deploy report: sf project deploy report --job-id 0AfDR00003FsLWR0A3 --wait 5

before

  dreamhouse-lwc git:(main) ✗ sf project deploy report --job-id 0AfDR00003FsLWR0A3 --wait 5
Status: Succeeded | ████████████████████████████████████████ | 91/91 Components
Warning: CustomField, Broker__c.Broker_Id__c, returned from org, but not found in the local project
Warning: CustomField, Broker__c.Mobile_Phone__c, returned from org, but not found in the local project
Warning: CustomField, Broker__c.Phone__c, returned from org, but not found in the local project
Warning: CustomField, Broker__c.Picture_IMG__c, returned from org, but not found in the local project
Warning: CustomField, Broker__c.Picture__c, returned from org, but not found in the local project
Warning: CustomField, Broker__c.Title__c, returned from org, but not found in the local project
Warning: CustomField, Property__c.Address__c, returned from org, but not found in the local project
Warning: CustomField, Property__c.Assessed_Value__c, returned from org, but not found in the local project
Warning: CustomField, Property__c.Baths__c, returned from org, but not found in the local project
Warning: CustomField, Property__c.Beds__c, returned from org, but not found in the local project
Warning: CustomField, Property__c.Broker__c, returned from org, but not found in the local project
Warning: CustomField, Property__c.City__c, returned from org, but not found in the local project
Warning: CustomField, Property__c.Date_Agreement__c, returned from org, but not found in the local project
...

after

➜  dreamhouse-lwc git:(main) ✗ sf project deploy report --job-id 0AfDR00003FsLWR0A3 --wait 5
 ›   Warning: @salesforce/plugin-deploy-retrieve is a linked ESM module and cannot be auto-transpiled. Existing compiled source will be used instead.
Status: Succeeded | ████████████████████████████████████████ | 91/91 Components
0AfDR00003FsLWR0A3... Succeeded

Deploy Info
...

@cristiand391 cristiand391 merged commit 2d7fa28 into main May 14, 2024
70 checks passed
@cristiand391 cristiand391 deleted the wr/fixExtraWarning branch May 14, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants