Update clap to v4 #498
Merged
Update clap to v4 #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 61.02% // Head: 59.87% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #498 +/- ##
==========================================
- Coverage 61.02% 59.87% -1.16%
==========================================
Files 80 80
Lines 1827 1817 -10
==========================================
- Hits 1115 1088 -27
- Misses 712 729 +17
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
foresterre
approved these changes
Oct 1, 2022
|
bors r+ |
|
Thank you for the changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the
clapcrate to the just released v4.0. Am currently updating many of my own crates to v4 and found issue #496 as part of the Hacktoberfest event.I tried to keep the implementation as much as-is as possible, but especially clap's help message styling changed a lot with v4.
You might wonder the
AppSettings::DeriveDisplayOrderbeing removed, but it is not needed anymore, as this is the new default now. Besides that, I used theValueEnumderive a lot to have the possible values of enums provided to clap. This may have invaded some modules with clap use statements, so just let me know if you don't want that, and I'll think of something else.This is my first contribution to this project, so I just wanted to say: Thank you for this awesome project, I'm using it regularly for my project and love it 🚀.