Remove cursor decrement from advance_cursor_while
#73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the cursor would end up pointing to the last element that passed, rather than the first element that fails.
This updates the existing `check_move_forward_while` test cases, and adds a new `check_move_forward_while_fast_fail` test case for testing that a cursor isn't decremented if the first element fails the predicate.
|
Whoops, forgot to update test cases. I've done so and added one for testing that the cursor isn't decremented in the edge case where the first element fails the predicate. |
|
Thanks a lot for both the clear issue and providing a fix! |
|
bors r+ |
foresterre
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the issues raised in #72.
The call to
decrement_cursorhas been removed and the method documentation has been expanded upon to communicate the behaviour a bit more explicitly.