fixed absolute command paths with spaces

[shenanigans]

There's this weird... safety net in forever-monitor that makes sure you haven't submitted arguments with your command. If you intend to pass an absolute path as a command, you'd better make sure it doesn't contain any spaces. In Windows in particular, it turns out that all executables are called exactly "C:/Program".

[jcrugzz]

@shenanigans if this is a special case for windows, we cannot have it break everything else. i.e: the tests should still pass

[shenanigans]

It's not a special case for windows, it's just far more likely to be a problem on windows due to the frequency of spaces appearing in common paths (and the infrequency of the same among *nix developers)

With my current environments, tests produce one failure on linux and nine failures on windows with and without the patch applied. As far as I am aware the functionality removed by this pull request is neither documented nor tested.

It just appears to be there to save your bacon if you accidentally do something like

child.start ("node path/to/script", { options:[ "arg0", "arg1" ] });

However, because it is splitting the executable path on spaces naively, it does not permit the execution of any path containing a space. One could do this non-naively but my opinion is that the entire functionality is unnecessary and probably does not exist in the wild. It doesn't appear to exist in the tests.

[shenanigans]

The pull request has been updated with the non-naive solution. *nix paths /with/escaped\ spaces will resolve correctly, as will windows paths "c:\with\spaces escaped by quotes". The argument-stripping functionality remains unchanged.

[fresheneesz]

Tested it out, seems to work, both with my "Program Files" node installation (that has whitespace) and with a script file with a path that has spaces. Looks good! Thanks!

[jcrugzz]

@shenanigans this LGTM. cc @indexzero

[indexzero]

This got merged. Will go out in forever@1.4.0