Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove y18n due to CVE 2020 7774 part 5 #1112

Merged
merged 4 commits into from
May 31, 2021
Merged

Remove y18n due to CVE 2020 7774 part 5 #1112

merged 4 commits into from
May 31, 2021

Conversation

thenengah
Copy link
Contributor

No description provided.

@thenengah thenengah mentioned this pull request May 30, 2021
Closed
kibertoad
kibertoad requested changes May 30, 2021
View reviewed changes
Copy link
Contributor

@kibertoad kibertoad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a pefectly valid behaviour to fail when non-existing file is referenced.
Instead, an empty config should be used when no config is specified.

@thenengah
Copy link
Contributor Author

It's a pefectly valid behaviour to fail when non-existing file is referenced.
Instead, an empty config should be used when no config is specified.

@kibertoad Got it; made updates, let me know what you think.

@kibertoad kibertoad merged commit 35a4062 into foreversd:master May 31, 2021
@thenengah
Copy link
Contributor Author

😄

@akatona84 akatona84 mentioned this pull request Jun 10, 2021
Closed
This was referenced Jul 16, 2024
Open
Open
@WontonSam WontonSam mentioned this pull request Sep 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kibertoad kibertoad kibertoad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thenengah @kibertoad