Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #603: Now use a rolling restart to minimize downtime. #665

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

markstos
Copy link

No description provided.

@ilanbiala
Copy link

@indexzero is this going to get merged in?

Copy link
Contributor

@kibertoad kibertoad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be a default behaviour. Please modify this to be a configuration option.

@markstos
Copy link
Author

markstos commented Jan 7, 2019

This shouldn't be a default behaviour.

Why not? It minimizes downtime.

@kibertoad
Copy link
Contributor

@markstos Because it modifies default behaviour that existing production environments might be relying on. Such changes should be opt-in, not opt-out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants