Fix findById which was using double rather than triple equals operator #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uble rather than triple equals operator.
|
Please verify and merge this pull request. Bug #699 has been giving us serious operational trouble since April. Inadvertently stopping all processes managed by forever by issuing a "stop 0" is a very serious bug. Thank you for your consideration. |
indexzero
added a commit
that referenced
this pull request
Sep 5, 2015
Fix findById which was using double rather than triple equals operator
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title, this hopefully allows findById to work correctly and fixes #699 (forever stop id seems to stop all processes).
I've not been able to run the "npm test" suite - i've filed #755 for this.
Of course I have tested this on our local build machine and now undeploying the first test environment to be setup on the machine (i.e. has a forever process as index 0) now no longer kills every nodejs process (i.e. evey test environment) on the same box.