Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build #807

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix build #807

wants to merge 1 commit into from

Conversation

macobo
Copy link

@macobo macobo commented Feb 4, 2016

For some reason the test suite needs to have cwd set to root dir. This needs to be explicit because of some change some other PR made.

@@ -285,11 +286,12 @@ var getOptions = cli.getOptions = function (file) {

if (configs && configs.length) {
return configs.map(function (conf) {
return assignSpawnWith(objectAssign(clone(options), conf));
var startupConfig = setDefaults(objectAssign(clone(options), conf));
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why this is correct btw - this gives config values higher priority than cli flags. Surely this should be reversed?

@kibertoad
Copy link
Contributor

@macobo Is this still relevant? What was broken about the build?

@macobo
Copy link
Author

macobo commented Jan 5, 2019

@kibertoad Not sure; I think I was trying to build from source years ago and ran into this issue.

If everything is stable, feel free to close this PR.

@kibertoad
Copy link
Contributor

Thank you for clarification!

@kibertoad kibertoad closed this Jan 5, 2019
@kibertoad kibertoad reopened this Jan 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants