Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed dependency on timespan #956

Conversation

reaktivo
Copy link

@reaktivo reaktivo commented Oct 2, 2017

Will change the display of uptime from:
38d 16h 1m 23s
into
38:16:1:23.49

See https://nodesecurity.io/advisories/533

See #955

@dtrawins
Copy link

Is there some ETA for merging it and new release?

@bennycode
Copy link

@reaktivo: Great that you fixed forever's security issue.

It could also be fixed using Moment.js:

const moment = require('moment');
const uptime = moment.utc(new Date().getTime() - proc.ctime).format('DD:HH:mm:ss.SSS');
return proc.running ? uptime.yellow : "STOPPED".red;

@marin-liovic
Copy link

Still no ETA?

@bennycode
Copy link

It looks like that this project here is dead...

@indexzero, @mmalecki, @AvianFlu, @bmeck, do you think otherwise?

@marin-liovic
Copy link

I see @asci approved changes. So it looks like somebody is still on the project...

@asci
Copy link

asci commented Oct 24, 2017

I'm not the maintainer of this project :)

@bennycode
Copy link

I also approved it. ✔️

Now we need to find someone to merge it and to make a release version. 😁

Telling from npm, these are the "Magic Five" (in alphabetical order) who have the power to do it:

@jiafangtao
Copy link

Hello @bmeck @indexzero @jcrugzz @julianduque, do you have ETA for new release with this fix? Regards and thanks.

@roblav96
Copy link

roblav96 commented Jan 26, 2018

@reaktivo @asci @bennyn I published this PR to a temporary package on npm forever-timespan-patch for the time being. Hope this all gets resolved. Thanks!

Copy link

@roblav96 roblav96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kibertoad
Copy link
Contributor

Let's continue the discussion here: #1014
I've explained in the description of PR why I ended up implementing a different approach instead of just merging this PR.

@kibertoad kibertoad closed this Jan 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants