-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: repository improvements #10
Conversation
package.json
Outdated
"src/remix-app-for-testing" | ||
], | ||
"peerDependencies": { | ||
"@remix-run/react": "^1.18.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be bumped down to 1.15, the package should work with all versions above it because it requires useNavigate from @remix-run/react
@@ -52,6 +52,7 @@ export default defineConfig({ | |||
["react-dom"]: "ReactDOM", | |||
["@remix-run/react"]: "@remix-run/react", | |||
}, | |||
assetFileNames: "stylesheet[extname]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you telling me I spent 2 days trying to figure out how to output the css file and this is all it took? 😮💨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome stuff @rossipedia, only thing I think we should change about this PR is the peerDependency on 1.18.1
Description
Buckle up :)
eslint
violationsprettier --write
to the whole repostylesheet.css
automatically via Vite'spostcss
integrationmoveStylesheet.js
src/remix-app-for-testing
as separate npm workspaces, so that we get proper package hoisting and deduplication of dependenciesremix-app-for-testing
, which now imports the dev tools the same way that users will.tailwind
dev process, since that is handled via Vite'spostcss
integration.react-refresh
eslint plugin, since it seemed like the codebase wasn't following that recommendation anyways (would be happy to bring it back and fix the violations if that's desired).react
,react-dom
, and@remix-run/react
aspeerDependencies
of the package so that users don't end up with multiple versions of those packages when integrating this one.tsconfig.json
withnoEmit: true
so you can typecheck the codebase from the CLI or in CI without actually building anything (since that's handled by Vite)postinstall
step inremix-app-for-testing
prepublish
NPM script toprepublishOnly
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Mainly just by using the
remix-app-for-testing
and verifying that everything still works as intended. There's not meant to be any functional changes to the final published package, this PR mainly focuses on how that package is built.