Fix/ open in VSCode for folder routes

[muchisx]

Description

I've found that the open in VSCode button wasn't working due to the file extensions being missing on the exec call and also the feature not currently working with Remix's folder routes.

This PR is aimed for the main Open with VSCode feature in the "Active segments" section of the app.

I still believe there's a bit more fixing to do to the other implementations of this open-source method, but this is the first step.

This is a localized fix, so it doesn't affect the other implementations of open-source.

Before

Before-1.mp4

After

After-1.mp4

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I manually tested it, on Windows 11 23H3.
If there are more types of tests to be done I would appreciate some guidance as I'm a bit lost in that subject!

Checklist:

• My code follows the guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings or errors
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[muchisx]

@AlemTuzlak Hi! I don't have permissions to add you as reviewer, any thoughts on this?

[AlemTuzlak]

@muchisx sorry, I've been on vacation the last 2 weeks, I'll try to sit down and go over this in detail on monday, from what I could see the code looks great

[omarsotillo]

Really looking forward to this 👏

[AlemTuzlak]

the first part of the check is redundant as you already checked if the source exists above, so this can be if(routeID)

[AlemTuzlak]

what happens if the routeID isn't there? I would expect it to always be sent, or?

[AlemTuzlak]

extract this into a function called openInVsCode or something because here the path is not normalized and above it is,
something like:

function openInVsCode(path: string){
  exec(`code -g "${normalizePath(path)}"`˙)
}

[AlemTuzlak]

can we also extract this and the lines 136-8 into a utility called findFileByExtension?

function findFileByExtension(prefix: string, filePaths: string[]){
  const file = files.find(file => allExtensions.some(ext => file === `${prefix}.${ext}`));
  return file
}

[AlemTuzlak]

I think the 2nd check is not needed because a folder wouldn't have an extension, I mean you could write it in but in practice I don't think anyone is doing something like folder.jsx/file.jsx or at least I'd hope not, or maybe even move this check into the return below, so type: fs.lstatSync(filePath).isFile() ? "file" : "directory"

[AlemTuzlak]

I have some minor changes I'd like to see, if you're not free to do them I can merge it and do it myself. Let me know! Great work and thank you so much for this

[muchisx]

@AlemTuzlak Awesome thanks! I left a few replies, I can give it some work later today but if you want to finish it you can go ahead!

[AlemTuzlak]

@muchisx I finished it up myself as I'm closing shop for today and I won't have time to work on it for a while, thank you so much! Wanted to credit you on twitter but no idea what your name there is

[muchisx]

🥳 Thank you!

It's same as gh, @muchisx !

[omarsotillo]

Hola! 👋 really cool to see this merged! just tried this morning updating to the new release version.

Sadly, for us, it does not work as expected and it even brings the server down when clicking on it. This is the error we get:

Let me know if you want me to open this as an issue

[AlemTuzlak]

@omarsotillo can you install 4.5.2 and see if it crashes?

[omarsotillo]

Hello @AlemTuzlak it works now! Thank you!