Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed unnecessary console logs #159

Merged
merged 3 commits into from
Oct 31, 2024
Merged

removed unnecessary console logs #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6239506
removed unnecessary console logs
abrulic1 Oct 31, 2024
e59d174
format fix
abrulic1 Oct 31, 2024
53b962d
updated version in package.json
abrulic1 Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion biome.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,11 @@
"recommended": true,
"suspicious": {
"recommended": true,
"noExplicitAny": "off"
"noExplicitAny": "off",
"noConsole": {
"level": "error",
"options": { "allow": ["assert", "error", "info", "warn"] }
}
},
"style": {
"recommended": true
Expand Down
85 changes: 47 additions & 38 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you didn't bump the minor

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "remix-development-tools",
"description": "Remix development tools - a set of tools for developing/debugging Remix.run apps",
"author": "Alem Tuzlak",
"version": "4.7.3",
"version": "4.7.4",
"license": "MIT",
"keywords": [
"remix",
Expand Down Expand Up @@ -99,7 +99,7 @@
"vite": ">=5.0.0"
},
"devDependencies": {
"@biomejs/biome": "1.8.3",
"@biomejs/biome": "^1.9.4",
"@remix-run/dev": "^2.9.1",
"@remix-run/node": "^2.9.1",
"@remix-run/react": "^2.9.1",
Expand Down
2 changes: 2 additions & 0 deletions scripts/icons.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,12 @@ const files = glob.sync("**/*.svg", {
cwd: inputDir,
})
if (files.length === 0) {
// biome-ignore lint/suspicious/noConsole: disable noConsole rule for this line
console.log(`No SVG files found in ${inputDirRelative}`)
process.exit(0)
}
// The relative paths are just for cleaner logs
// biome-ignore lint/suspicious/noConsole: disable noConsole rule for this line
console.log(`Generating sprite for ${inputDirRelative}`)

generateSvgSprite({
Expand Down
2 changes: 2 additions & 0 deletions scripts/setup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,15 @@ import chalk from "chalk"
import prompt from "prompt"
// Helper method used to verify the run
const verifyRun = async () => {
// biome-ignore lint/suspicious/noConsole: disable noConsole rule for this line
console.log("About to execute the command")

const { sure } = await prompt.get([
{ name: "sure", description: "Are you sure? (y/n)", type: "string", required: true },
])

if (sure !== "y") {
// biome-ignore lint/suspicious/noConsole: disable noConsole rule for this line
console.log(chalk.bold.red("Command aborted!\n"))
process.exit(1)
}
Expand Down
1 change: 0 additions & 1 deletion src/client/components/jsonRenderer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ const JsonRenderer = ({ data }: JsonRendererProps) => {
value
.then((res) => {
if (!ref.current) return
console.log(res)
setJson((json: any) => ({
...json,
[key]: res,
Expand Down
10 changes: 5 additions & 5 deletions src/client/hooks/useDevServerConnection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const updateRouteInfo = (
const { data, type } = event
const { id, ...rest } = data
// Get existing route
const existingRouteInfo = !includeServerInfo ? routes?.[id] : routes?.[id] ?? server?.routes?.[id]
const existingRouteInfo = !includeServerInfo ? routes?.[id] : (routes?.[id] ?? server?.routes?.[id])
let newRouteData = [...(existingRouteInfo?.[type === "loader" ? "loaders" : "actions"] || []), rest]
// Makes sure there are no more than 20 entries per loader/action
newRouteData = cutArrayToLastN(newRouteData, 20)
Expand All @@ -40,10 +40,10 @@ const updateRouteInfo = (
highestExecutionTime: max,
averageExecutionTime: Number(Number(total / newRouteData.length).toFixed(2)),
loaderTriggerCount: type === "loader" ? loaderTriggerCount + 1 : loaderTriggerCount,
loaders: type === "loader" ? newRouteData : existingRouteInfo?.loaders ?? [],
actions: type === "action" ? newRouteData : existingRouteInfo?.actions ?? [],
lastLoader: type === "loader" ? rest : existingRouteInfo?.lastLoader ?? {},
lastAction: type === "action" ? rest : existingRouteInfo?.lastAction ?? {},
loaders: type === "loader" ? newRouteData : (existingRouteInfo?.loaders ?? []),
actions: type === "action" ? newRouteData : (existingRouteInfo?.actions ?? []),
lastLoader: type === "loader" ? rest : (existingRouteInfo?.lastLoader ?? {}),
lastAction: type === "action" ? rest : (existingRouteInfo?.lastAction ?? {}),
actionTriggerCount: type === "action" ? actionTriggerCount + 1 : actionTriggerCount,
}
}
Expand Down
3 changes: 2 additions & 1 deletion src/server/logger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ const log = (message: string) => {
if (config.silent) {
return
}
// eslint-disable-next-line no-console

// biome-ignore lint/suspicious/noConsole: disable noConsole rule for this line
console.log(message)
}

Expand Down
1 change: 1 addition & 0 deletions src/vite/plugin.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,7 @@ export const remixDevTools: (args?: RemixViteConfig) => Plugin[] = (args) => {
async configResolved(resolvedViteConfig) {
if (!args?.suppressDeprecationWarning && resolvedViteConfig.appType === "custom") {
// Log a warning message
// biome-ignore lint/suspicious/noConsole: disable noConsole rule for this line
console.log(
`\n\n⚠️ ${chalk.yellowBright("remix-development-tools")} are going to be deprecated and will be renamed to ${chalk.greenBright("react-router-devtools ")} when React Router v7 is released ⚠️`,
`\n⚠️ Set suppressDeprecationWarning to true in your ${chalk.greenBright("vite.config.ts")} file to silence this warning ⚠️`
Expand Down
Loading