Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SQL] fix tmPreferences and tests #10

Merged
merged 5 commits into from
Oct 13, 2021
Merged

[SQL] fix tmPreferences and tests #10

merged 5 commits into from
Oct 13, 2021

Conversation

jrappen
Copy link

@jrappen jrappen commented Oct 12, 2021

No description provided.

@jrappen
[SQL] fix tmPreferences
c283637 
- remove redundant lines
- convert indentation to tabs
@jrappen
[SQL] split tests into separate ones for:
700f8f8 
- symbols
- indentation
@jrappen jrappen mentioned this pull request Oct 12, 2021
Open
michaelblyons
michaelblyons suggested changes Oct 13, 2021
View reviewed changes
SQL/Indentation Rules - Comments.tmPreferences Show resolved Hide resolved
SQL/tests/symbols/syntax_test_symbols_tsql.sql Outdated Show resolved Hide resolved
SQL/MySQL.sublime-syntax Show resolved Hide resolved
@jrappen
Copy link
Author

jrappen commented Oct 13, 2021

@michaelblyons appreciate the feedback

@keith-hall keith-hall merged commit 0d66768 into forkeith:sql Oct 13, 2021
@keith-hall
Copy link

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keith-hall keith-hall keith-hall approved these changes

@michaelblyons michaelblyons michaelblyons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrappen @keith-hall @michaelblyons