Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update offatom test to 0-based indexing #230

Merged
merged 1 commit into from
Nov 11, 2024
Merged

update offatom test to 0-based indexing #230

merged 1 commit into from
Nov 11, 2024

Conversation

diogomart
Copy link
Contributor

Forgot to update the test. Indices of atoms in SMARTS strings used in typing now start at zero

@diogomart diogomart requested a review from rwxayheee November 11, 2024 18:16
@diogomart
Copy link
Contributor Author

Thanks!

@diogomart diogomart merged commit c938ebd into develop Nov 11, 2024
1 check passed
@diogomart diogomart deleted the fix_offatom_test branch December 4, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwxayheee rwxayheee rwxayheee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diogomart @rwxayheee