Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for passing new, SMARTS-specified atomtypes #56

Merged
merged 6 commits into from
Jul 26, 2023

Conversation

althea-hansel
Copy link
Contributor

No description provided.

@althea-hansel althea-hansel requested a review from diogomart July 24, 2023 22:57
@althea-hansel althea-hansel linked an issue Jul 24, 2023 that may be closed by this pull request
@diogomart
Copy link
Contributor

Works great for a single new type, but not for multiple, for example:

mk_prepare_ligand.py -i has-selenium.sdf -aa '[{"smarts": "[Se]", "atype": "SA"}, {"smarts": "[Ch3][C]", "IDX": [1], "atype": "OX"}]' -
mk_prepare_ligand.py -i has-selenium.sdf -aa '{"smarts": "[Se]", "atype": "SA"}' -aa '{"smarts": "[Ch3][C]", "IDX": [1], "atype": "OX"}'

Maybe this was not the intended syntax?

@althea-hansel
Copy link
Contributor Author

althea-hansel commented Jul 24, 2023

Correct syntax is

mk_prepare_ligand.py -i has-selenium.sdf -aa '{"smarts": "[Se]", "atype": "SA"} {"smarts": "[Ch3][C]", "IDX": [1], "atype": "OX"}' 

@diogomart diogomart merged commit 9e1a1b7 into reactive Jul 26, 2023
@diogomart diogomart deleted the add_atom_types branch July 26, 2023 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose option to append SMARTS and atom type to default list
2 participants