Skip to content

Commit

Permalink
fix(deps): upgrade to the latest beta of the js-plugin
Browse files Browse the repository at this point in the history
BREAKING CHANGE: the minimum supported version of node is now v18.19.0 and v21 has been dropped
  • Loading branch information
travi committed Sep 24, 2024
1 parent c7d3d6b commit 05c5e54
Show file tree
Hide file tree
Showing 6 changed files with 63 additions and 19 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/node-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,9 @@ jobs:
strategy:
matrix:
node:
- 18.17.0
- 18.19.0
- 20.6.1
- 22.0.0
steps:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
- name: Setup node
Expand Down
7 changes: 6 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,12 @@ const {scaffold, extendEslintConfig} = await import('./lib/index.mjs');
},
decisions => ({
...javascriptPlugin,
scaffold: options =>javascriptPlugin.scaffold({...options, decisions, unitTestFrameworks: {}})
scaffold: options => javascriptPlugin.scaffold({
...options,
decisions,
configs: {},
plugins: {unitTestFrameworks: {}}
})
})
);
})();
Expand Down
7 changes: 6 additions & 1 deletion example.js
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,12 @@ stubbedFs({node_modules: stubbedNodeModules});
},
decisions => ({
...javascriptPlugin,
scaffold: options => javascriptPlugin.scaffold({...options, decisions, unitTestFrameworks: {}})
scaffold: options => javascriptPlugin.scaffold({
...options,
decisions,
configs: {},
plugins: {unitTestFrameworks: {}}
})
})
);
})();
55 changes: 43 additions & 12 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"version": "0.0.0-semantically-released",
"type": "module",
"engines": {
"node": "^18.17.0 || >=20.6.1"
"node": "^18.19.0 || ^20.6.1 || >=22"
},
"author": "Matt Travi <npm@travi.org> (https://matt.travi.org)",
"repository": "form8ion/eslint-config-extender",
Expand Down Expand Up @@ -55,7 +55,7 @@
"dependencies": {
"@form8ion/config-file": "^1.1.2",
"@form8ion/core": "^4.7.1",
"@form8ion/javascript": "^12.0.0",
"@form8ion/javascript": "^13.0.0-beta.13",
"@form8ion/javascript-core": "^11.0.0",
"@form8ion/project": "^19.0.1",
"deepmerge": "^4.2.2"
Expand Down
6 changes: 4 additions & 2 deletions test/integration/features/step_definitions/common-steps.js
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,10 @@ When('the high-level scaffolder is executed', async function () {
decisions => ({
scaffold: options => scaffoldJs({
...options,
unitTestFrameworks: {},
packageTypes: {[pluginName]: {scaffolder: scaffoldEslintConfig}},
plugins: {
unitTestFrameworks: {},
packageTypes: {[pluginName]: {scaffold: scaffoldEslintConfig}}
},
configs: {eslint: {scope: `@${any.word()}`}},
decisions
})
Expand Down

0 comments on commit 05c5e54

Please sign in to comment.