fix(keywords): stopped modifying existing list when no new tags are p…

…rovided
form8ion · Jun 23, 2021 · 3c0bdc2 · 3c0bdc2
1 parent 4fa7958
commit 3c0bdc2
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 2 deletions.
diff --git a/src/package-test.js b/src/package-test.js
@@ -70,6 +70,21 @@ suite('package.json lifter', () => {
         JSON.stringify({...packageJsonContents, scripts: {}, keywords: [...existingKeywords, ...tags]}, null, 2)
       );
     });
+
+    test('that keywords are not modified when some keywords already exist but none are provided', async () => {
+      const existingKeywords = any.listOf(any.word);
+      fs.readFile
+        .withArgs(pathToPackageJson, 'utf8')
+        .resolves(JSON.stringify({...packageJsonContents, scripts: {}, keywords: existingKeywords}));
+
+      await liftPackage({projectRoot, scripts: {}});
+
+      assert.calledWith(
+        fs.writeFile,
+        pathToPackageJson,
+        JSON.stringify({...packageJsonContents, scripts: {}, keywords: existingKeywords}, null, 2)
+      );
+    });
   });
 
   suite('dependencies', () => {

diff --git a/src/package.js b/src/package.js
@@ -1,6 +1,6 @@
 import {promises as fs} from 'fs';
 import {info} from '@travi/cli-messages';
-import {installDependencies, PROD_DEPENDENCY_TYPE, DEV_DEPENDENCY_TYPE} from '@form8ion/javascript-core';
+import {DEV_DEPENDENCY_TYPE, installDependencies, PROD_DEPENDENCY_TYPE} from '@form8ion/javascript-core';
 
 export default async function ({
   projectRoot,
@@ -24,7 +24,9 @@ export default async function ({
         {
           ...existingPackageJsonContents,
           scripts: {...existingPackageJsonContents.scripts, ...scripts},
-          keywords: existingPackageJsonContents.keywords ? [...existingPackageJsonContents.keywords, ...tags] : tags
+          ...tags && {
+            keywords: existingPackageJsonContents.keywords ? [...existingPackageJsonContents.keywords, ...tags] : tags
+          }
         },
         null,
         2