feat(install): enabled installing in the context of the project root

form8ion · Dec 9, 2020 · d38bc23 · d38bc23
1 parent 597bcc7
commit d38bc23
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/src/package-test.js b/src/package-test.js
@@ -80,8 +80,8 @@ suite('package.json lifter', () => {
     test('that dependencies and devDependencies are installed when provided', async () => {
       await liftPackage({projectRoot, dependencies, devDependencies});
 
-      assert.calledWith(jsCore.installDependencies, dependencies, jsCore.PROD_DEPENDENCY_TYPE);
-      assert.calledWith(jsCore.installDependencies, devDependencies, jsCore.DEV_DEPENDENCY_TYPE);
+      assert.calledWith(jsCore.installDependencies, dependencies, jsCore.PROD_DEPENDENCY_TYPE, projectRoot);
+      assert.calledWith(jsCore.installDependencies, devDependencies, jsCore.DEV_DEPENDENCY_TYPE, projectRoot);
     });
 
     test('that eslint devDependencies are added when provided', async () => {
@@ -98,15 +98,15 @@ suite('package.json lifter', () => {
     test('that only dependencies are installed when no dev-dependencies are provided', async () => {
       await liftPackage({projectRoot, dependencies});
 
-      assert.calledWith(jsCore.installDependencies, dependencies, jsCore.PROD_DEPENDENCY_TYPE);
-      assert.calledWith(jsCore.installDependencies, [], jsCore.DEV_DEPENDENCY_TYPE);
+      assert.calledWith(jsCore.installDependencies, dependencies, jsCore.PROD_DEPENDENCY_TYPE, projectRoot);
+      assert.calledWith(jsCore.installDependencies, [], jsCore.DEV_DEPENDENCY_TYPE, projectRoot);
     });
 
     test('that only dev-dpendencies are installed when no dependencies are provided', async () => {
       await liftPackage({projectRoot, devDependencies});
 
-      assert.calledWith(jsCore.installDependencies, devDependencies, jsCore.DEV_DEPENDENCY_TYPE);
-      assert.calledWith(jsCore.installDependencies, [], jsCore.PROD_DEPENDENCY_TYPE);
+      assert.calledWith(jsCore.installDependencies, devDependencies, jsCore.DEV_DEPENDENCY_TYPE, projectRoot);
+      assert.calledWith(jsCore.installDependencies, [], jsCore.PROD_DEPENDENCY_TYPE, projectRoot);
     });
   });
 

diff --git a/src/package.js b/src/package.js
@@ -26,9 +26,10 @@ export default async function ({projectRoot, scripts, tags, dependencies, devDep
 
   info('Installing dependencies');
 
-  await installDependencies(dependencies || [], PROD_DEPENDENCY_TYPE);
+  await installDependencies(dependencies || [], PROD_DEPENDENCY_TYPE, projectRoot);
   await installDependencies(
     [...devDependencies || [], ...eslintDevDependencies || []],
-    DEV_DEPENDENCY_TYPE
+    DEV_DEPENDENCY_TYPE,
+    projectRoot
   );
 }