fix(package-json): parsed the file properly

form8ion · Apr 25, 2020 · e4a5e94 · e4a5e94
1 parent 0e62c55
commit e4a5e94
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/scripts-test.js b/src/scripts-test.js
@@ -22,14 +22,16 @@ suite('scripts lifter', () => {
     const scripts = any.simpleObject();
     const originalScripts = any.simpleObject();
     const packageJsonContents = any.simpleObject();
-    fs.readFile.withArgs(pathToPackageJson, 'utf8').resolves({...packageJsonContents, scripts: originalScripts});
+    fs.readFile
+      .withArgs(pathToPackageJson, 'utf8')
+      .resolves(JSON.stringify({...packageJsonContents, scripts: originalScripts}));
 
     await liftScripts({projectRoot, scripts});
 
     assert.calledWith(
       fs.writeFile,
       pathToPackageJson,
-      {...packageJsonContents, scripts: {...originalScripts, ...scripts}}
+      JSON.stringify({...packageJsonContents, scripts: {...originalScripts, ...scripts}})
     );
   });
 

diff --git a/src/scripts.js b/src/scripts.js
@@ -4,11 +4,11 @@ export default async function ({projectRoot, scripts}) {
   if (scripts) {
     const pathToPackageJson = `${projectRoot}/package.json`;
 
-    const existingPackageJsonContents = await fs.readFile(pathToPackageJson, 'utf8');
+    const existingPackageJsonContents = JSON.parse(await fs.readFile(pathToPackageJson, 'utf8'));
 
     await fs.writeFile(
       pathToPackageJson,
-      {...existingPackageJsonContents, scripts: {...existingPackageJsonContents.scripts, ...scripts}}
+      JSON.stringify({...existingPackageJsonContents, scripts: {...existingPackageJsonContents.scripts, ...scripts}})
     );
   }
 }