Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to use an id property in their entities #12

Merged
merged 2 commits into from
Feb 11, 2024

Conversation

Baptouuuu
Copy link
Member

Problem

The SQL adapter uses a column id for entities, optional entities and collections to reference the parent aggregate id. This name prevents users to have a property named id in their entities.

Solution

Rename id to aggregateId. Users should not reference the concept of an aggregate in their entities, thus reducing the probability of collisions.

@Baptouuuu Baptouuuu self-assigned this Feb 11, 2024
Copy link

codecov bot commented Feb 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9d8fc31) 97.64% compared to head (1bc4a2c) 97.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop      #12   +/-   ##
==========================================
  Coverage      97.64%   97.64%           
  Complexity       470      470           
==========================================
  Files             78       78           
  Lines           3182     3182           
==========================================
  Hits            3107     3107           
  Misses            75       75           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Baptouuuu Baptouuuu merged commit f9275d5 into develop Feb 11, 2024
15 checks passed
@Baptouuuu Baptouuuu deleted the fix-id-collisions branch February 11, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant