Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Set
s are used to describe a unique collection of properties, entities, etc... Even though this is the right structure conceptually, it adds lots of operations to make sure there are no duplicated objects. But the way the objects are created there can never be multiple instances of the same object inside a collection.The result is that the time took to verify this unicity is wasted and impacts the overall performance of the ORM.
Solution
Replace
Set
s bySequence
s.Result
When running the benchmark script to list 100k aggregates this PR results in 19% time reduction: