Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MatchingOptional property #29

Merged
merged 2 commits into from
Jul 6, 2024
Merged

Fix MatchingOptional property #29

merged 2 commits into from
Jul 6, 2024

Conversation

Baptouuuu
Copy link
Member

Problem

In the CI when this property is run in a sequence of properties it randomly fails.

After investigation the query run is not(endsWith) opposed to the equality from previous queries in the same property. This is a bad copy/paste from another property, the aimed query was not(equality).

When checking the documentation of Elasticsearch it's indicated that a wildcard query starting with *, which is what endsWith is translated to, is an expensive query that should be avoided.

Solution

  • Fix property to use not(equality)
  • Add a Known issues chapter in the documentation

@Baptouuuu Baptouuuu added the bug Something isn't working label Jul 6, 2024
@Baptouuuu Baptouuuu self-assigned this Jul 6, 2024
@Baptouuuu Baptouuuu merged commit 4178a47 into develop Jul 6, 2024
19 checks passed
@Baptouuuu Baptouuuu deleted the fix-property branch July 6, 2024 12:15
@Baptouuuu Baptouuuu mentioned this pull request Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant