Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pgtesting): add package #24

Merged
merged 7 commits into from
Dec 16, 2022
Merged

feat(pgtesting): add package #24

merged 7 commits into from
Dec 16, 2022

Conversation

gfyrag
Copy link
Contributor

@gfyrag gfyrag commented Dec 11, 2022

No description provided.

@codecov
Copy link

codecov bot commented Dec 11, 2022

Codecov Report

Merging #24 (d251947) into main (2c8ab19) will not change coverage.
The diff coverage is n/a.

❗ Current head d251947 differs from pull request most recent head ef2d525. Consider uploading reports for the commit ef2d525 to get more accurate results

@@           Coverage Diff           @@
##             main      #24   +/-   ##
=======================================
  Coverage   43.88%   43.88%           
=======================================
  Files          18       18           
  Lines         572      572           
=======================================
  Hits          251      251           
  Misses        301      301           
  Partials       20       20           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Comment on lines 67 to 69
func DestroyPostgresServer() {
srv.Close()
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add support for implicit t.Cleanup()? 🤔

pgtesting/pkg/postgres.go Outdated Show resolved Hide resolved
pgtesting/pkg/postgres.go Outdated Show resolved Hide resolved
pgtesting/pkg/postgres.go Outdated Show resolved Hide resolved
pgtesting/pkg/postgres.go Show resolved Hide resolved
antoinegelloz
antoinegelloz previously approved these changes Dec 13, 2022
@gfyrag gfyrag merged commit 232f73d into main Dec 16, 2022
@gfyrag gfyrag deleted the feat/pgtesting branch December 16, 2022 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants