feat: faster timestamp queries #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Clément Salaün <salaun.clement@gmail.com>
Signed-off-by: Clément Salaün <salaun.clement@gmail.com>
Signed-off-by: Clément Salaün <salaun.clement@gmail.com>
4 tasks
Signed-off-by: Clément Salaün <salaun.clement@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/v1.10 #479 +/- ##
================================================
Coverage ? 64.20%
================================================
Files ? 152
Lines ? 14171
Branches ? 0
================================================
Hits ? 9098
Misses ? 4484
Partials ? 589 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Clément Salaün <salaun.clement@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces some improvements on temporal queries on transactions, by reviewing the way the
endTimeparameter is compiled.We leverage the property on v1 stating that
∀A,B, (A.timestamp > B.timestamp) ⇒ (A.txid > B.txid)to reduce the search space with an upper-bounded txid.An index is added on the transactions table, to efficiently sort and query timestamps.
Internal: Fixes ENG-573