Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bankingcircle connector #45

Merged
merged 5 commits into from
Nov 21, 2022
Merged

Conversation

darkmatterpool
Copy link
Contributor

No description provided.

@darkmatterpool darkmatterpool self-assigned this Oct 13, 2022
@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Merging #45 (66bd147) into main (c7066e4) will decrease coverage by 1.14%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
- Coverage   25.50%   24.35%   -1.15%     
==========================================
  Files          81       86       +5     
  Lines        3945     4143     +198     
==========================================
+ Hits         1006     1009       +3     
- Misses       2845     3041     +196     
+ Partials       94       93       -1     
Impacted Files Coverage Δ
internal/app/api/module.go 0.00% <ø> (ø)
internal/pkg/connectors/bankingcircle/client.go 0.00% <0.00%> (ø)
internal/pkg/connectors/bankingcircle/config.go 0.00% <0.00%> (ø)
internal/pkg/connectors/bankingcircle/loader.go 0.00% <0.00%> (ø)
...kg/connectors/bankingcircle/task_fetch_payments.go 0.00% <0.00%> (ø)
...ernal/pkg/connectors/bankingcircle/task_resolve.go 0.00% <0.00%> (ø)
...rnal/pkg/connectors/dummypay/task_generate_file.go 72.54% <0.00%> (+2.94%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Lawrence Zawila <113581282+darkmatterpool@users.noreply.github.com>
Signed-off-by: Lawrence Zawila <113581282+darkmatterpool@users.noreply.github.com>
Signed-off-by: Lawrence Zawila <113581282+darkmatterpool@users.noreply.github.com>
@darkmatterpool darkmatterpool marked this pull request as ready for review November 16, 2022 21:58
@flemzord flemzord requested a review from gfyrag November 16, 2022 21:59
"net/http"
"time"

"github.com/numary/go-libs/sharedlogging"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update to formancehq instead of numary.

@darkmatterpool darkmatterpool merged commit b1f5192 into main Nov 21, 2022
@darkmatterpool darkmatterpool deleted the feat/connector-banking-circle branch November 21, 2022 13:36
flemzord pushed a commit that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants