Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor #46

Merged
merged 9 commits into from
Oct 21, 2022
Merged

feat: refactor #46

merged 9 commits into from
Oct 21, 2022

Conversation

darkmatterpool
Copy link
Contributor

Signed-off-by: Lawrence Zawila <113581282+darkmatterpool@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Oct 15, 2022

Codecov Report

Merging #46 (37c1bae) into main (90dc6d9) will decrease coverage by 1.55%.
The diff coverage is 14.78%.

@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
- Coverage   29.60%   28.04%   -1.56%     
==========================================
  Files          65       70       +5     
  Lines        3091     3451     +360     
==========================================
+ Hits          915      968      +53     
- Misses       2090     2399     +309     
+ Partials       86       84       -2     
Impacted Files Coverage Δ
cmd/root.go 0.00% <0.00%> (ø)
cmd/server.go 0.00% <0.00%> (ø)
cmd/version.go 0.00% <0.00%> (ø)
internal/app/api/connector.go 0.00% <0.00%> (ø)
internal/app/api/connectormodule.go 0.00% <0.00%> (ø)
internal/app/api/health.go 0.00% <0.00%> (ø)
internal/app/api/module.go 0.00% <0.00%> (ø)
internal/app/api/payments.go 0.00% <0.00%> (ø)
internal/app/api/queryparam.go 0.00% <0.00%> (ø)
internal/app/api/recovery.go 0.00% <0.00%> (ø)
... and 63 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Lawrence Zawila <113581282+darkmatterpool@users.noreply.github.com>
@darkmatterpool darkmatterpool marked this pull request as ready for review October 17, 2022 11:25
@darkmatterpool darkmatterpool self-assigned this Oct 17, 2022
internal/app/api/module.go Outdated Show resolved Hide resolved
gfyrag
gfyrag previously approved these changes Oct 20, 2022
Copy link
Contributor

@gfyrag gfyrag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I definitely don't like all those linters which forces us to add ugly annotations to the code.
We don't need tools which say us a function is too long or an interface implementation is empty.

cmd/root.go Outdated Show resolved Hide resolved
cmd/server.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
Signed-off-by: Lawrence Zawila <113581282+darkmatterpool@users.noreply.github.com>
@darkmatterpool darkmatterpool merged commit b969979 into main Oct 21, 2022
@darkmatterpool darkmatterpool deleted the feat/maintainability-refactoring branch October 21, 2022 14:24
flemzord pushed a commit that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants