Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: payments metadata #48

Merged
merged 3 commits into from
Oct 31, 2022
Merged

feat: payments metadata #48

merged 3 commits into from
Oct 31, 2022

Conversation

darkmatterpool
Copy link
Contributor

Signed-off-by: Lawrence Zawila <113581282+darkmatterpool@users.noreply.github.com>
@darkmatterpool darkmatterpool self-assigned this Oct 26, 2022
Signed-off-by: Lawrence Zawila <113581282+darkmatterpool@users.noreply.github.com>
Signed-off-by: Lawrence Zawila <113581282+darkmatterpool@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #48 (42e78a1) into main (cddea5e) will increase coverage by 0.43%.
The diff coverage is 39.42%.

@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
+ Coverage   27.81%   28.24%   +0.43%     
==========================================
  Files          70       71       +1     
  Lines        3477     3572      +95     
==========================================
+ Hits          967     1009      +42     
- Misses       2425     2470      +45     
- Partials       85       93       +8     
Impacted Files Coverage Δ
...rnal/pkg/connectors/dummypay/task_generate_file.go 74.25% <0.00%> (+2.97%) ⬆️
...nternal/pkg/connectors/dummypay/task_read_files.go 43.24% <0.00%> (ø)
internal/pkg/payments/payment.go 35.59% <ø> (+5.08%) ⬆️
internal/pkg/connectors/dummypay/config.go 43.18% <10.71%> (-56.82%) ⬇️
internal/pkg/ingestion/ingester.go 55.29% <44.44%> (-2.00%) ⬇️
internal/pkg/payments/metadata.go 55.55% <55.55%> (ø)
internal/pkg/connectors/dummypay/loader.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@darkmatterpool darkmatterpool marked this pull request as ready for review October 26, 2022 12:36
@@ -60,11 +61,38 @@ func (i *DefaultIngester) processBatch(ctx context.Context, batch Batch) ([]paym

var update bson.M

if elem.Adjustment != nil && elem.Payment != nil {
if elem.Adjustment == nil && elem.Payment == nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This case should have been covered by a unit test

@darkmatterpool darkmatterpool merged commit 4ea8b5d into main Oct 31, 2022
@darkmatterpool darkmatterpool deleted the feat/payments-metadata branch October 31, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants