Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GET /connectors returns 404 not found #50

Merged
merged 15 commits into from
Nov 23, 2022

Conversation

antoinegelloz
Copy link
Contributor

@antoinegelloz antoinegelloz commented Oct 28, 2022

this is a fix of my original PR, correcting the router of the new GET /connectors route

@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #50 (ff3160d) into main (a68bb1b) will decrease coverage by 0.01%.
The diff coverage is 14.00%.

@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
- Coverage   24.36%   24.34%   -0.02%     
==========================================
  Files          86       87       +1     
  Lines        4141     4140       -1     
==========================================
- Hits         1009     1008       -1     
+ Misses       3039     3038       -1     
- Partials       93       94       +1     
Impacted Files Coverage Δ
internal/app/api/connector.go 0.00% <ø> (ø)
internal/app/api/connectormodule.go 0.00% <ø> (ø)
internal/app/api/module.go 0.00% <0.00%> (ø)
...nternal/pkg/connectors/dummypay/task_read_files.go 44.73% <0.00%> (ø)
internal/pkg/connectors/duration.go 0.00% <0.00%> (ø)
internal/pkg/connectors/stripe/config.go 0.00% <ø> (ø)
internal/pkg/connectors/stripe/loader.go 0.00% <0.00%> (ø)
internal/pkg/connectors/stripe/task_main.go 0.00% <ø> (ø)
internal/pkg/integration/store.go 21.68% <0.00%> (ø)
...rnal/pkg/connectors/dummypay/task_generate_file.go 70.09% <16.66%> (-2.46%) ⬇️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

jdupas22
jdupas22 previously approved these changes Oct 31, 2022
altitude
altitude previously approved these changes Nov 2, 2022
internal/pkg/integration/store.go Outdated Show resolved Hide resolved
@antoinegelloz antoinegelloz dismissed stale reviews from altitude and jdupas22 via 1584791 November 9, 2022 19:54
@antoinegelloz antoinegelloz changed the title feat: Add GET /connectors to list all installed connectors fix: GET /connectors returns 404 not found Nov 21, 2022
flemzord
flemzord previously approved these changes Nov 22, 2022
gfyrag
gfyrag previously approved these changes Nov 23, 2022
darkmatterpool
darkmatterpool previously approved these changes Nov 23, 2022
@antoinegelloz antoinegelloz merged commit cf71535 into main Nov 23, 2022
@antoinegelloz antoinegelloz deleted the num-964-list-all-connectors branch November 23, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants