feat: currencycloud connector #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lawrence Zawila <113581282+darkmatterpool@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #54 +/- ##
==========================================
- Coverage 27.27% 25.55% -1.73%
==========================================
Files 73 81 +8
Lines 3707 3945 +238
==========================================
- Hits 1011 1008 -3
- Misses 2603 2843 +240
- Partials 93 94 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Lawrence Zawila <113581282+darkmatterpool@users.noreply.github.com>
flemzord
previously approved these changes
Nov 10, 2022
gfyrag
reviewed
Nov 14, 2022
| form.Add("login_id", c.loginID) | ||
| form.Add("api_key", c.apiKey) | ||
|
|
||
| resp, err := c.httpClient.PostForm(c.buildEndpoint("v2/authenticate/api"), form) |
There was a problem hiding this comment.
Forward a context to allow cancellation and open telemetry.
gfyrag
reviewed
Nov 14, 2022
| return nil, 0, fmt.Errorf("page must be greater than 0") | ||
| } | ||
|
|
||
| resp, err := c.httpClient.Get(c.buildEndpoint("v2/transactions/find?page=%d", page)) |
gfyrag
reviewed
Nov 14, 2022
| return nil | ||
| } | ||
|
|
||
| type Duration time.Duration |
There was a problem hiding this comment.
A previous PR (merged) has added a custom time.Duration.
I prefer this implementation.
Can you rebase and update?
@antoinegelloz
There was a problem hiding this comment.
The PR that you are talking about @gfyrag has indeed been merged, but not yet in main. It was based on this feat branch (https://github.com/formancehq/payments/pull/50/files) that still needs to be reviewed.
gfyrag
previously approved these changes
Nov 14, 2022
antoinegelloz
previously approved these changes
Nov 14, 2022
Signed-off-by: Lawrence Zawila <113581282+darkmatterpool@users.noreply.github.com>
darkmatterpool
dismissed stale reviews from antoinegelloz, gfyrag, and flemzord
via
5d210d9
antoinegelloz
approved these changes
Nov 14, 2022
gfyrag
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lawrence Zawila 113581282+darkmatterpool@users.noreply.github.com