feat: Improve OpenTelemetry #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyrag
changed the base branch from
main
to
feat/num-1050-payments-update-go-libs-to-last-version
gfyrag
commented
Nov 23, 2022
internal/app/api/module.go
Outdated
| rootMux.Use(recoveryHandler(httpRecoveryFunc)) | ||
| rootMux.Use(httpCorsHandler()) | ||
| rootMux.Use(httpServeFunc) | ||
|
|
||
| // Deprecated | ||
| rootMux.Path("/_health").Handler(healthHandler(client)) |
Codecov Report
@@ Coverage Diff @@
## feat/num-1050-payments-update-go-libs-to-last-version #60 +/- ##
=========================================================================================
- Coverage 24.39% 24.37% -0.03%
=========================================================================================
Files 87 87
Lines 4119 4147 +28
=========================================================================================
+ Hits 1005 1011 +6
- Misses 3019 3041 +22
Partials 95 95
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
gfyrag
force-pushed
the
feat/num-1040-payments-opentelemetry
branch
from
4fa9c54
to
9ed3b28
Compare
gfyrag
force-pushed
the
feat/num-1050-payments-update-go-libs-to-last-version
branch
from
8447e4c
to
a7d0c9b
Compare
gfyrag
force-pushed
the
feat/num-1040-payments-opentelemetry
branch
from
9ed3b28
to
c554519
Compare
antoinegelloz
approved these changes
Nov 25, 2022
flemzord
merged commit c8d90b3
into
feat/num-1050-payments-update-go-libs-to-last-version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve OpenTelemetry
Add instrumentation of mongodb library.
Add instrumentation of all http clients built by the connectors.
Also, add context on all functions using http clients, and use context provided by the framework.
On framework, add a trace initialization and forward context to connectors.
You can test locally, and see result on http://localhost:16686