feat: stripe transfers integration #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lawrence Zawila <113581282+darkmatterpool@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #64 +/- ##
==========================================
- Coverage 24.00% 23.47% -0.53%
==========================================
Files 89 91 +2
Lines 4233 4306 +73
==========================================
- Hits 1016 1011 -5
- Misses 3123 3200 +77
- Partials 94 95 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
flemzord
reviewed
Nov 30, 2022
swagger.yml
Outdated
| amount: | ||
| type: integer | ||
| example: 100 | ||
| currency: |
There was a problem hiding this comment.
Maybe replace for "asset", because in the whole project we are talking about asset and not currency.
| @@ -38,5 +38,5 @@ func (c Config) BuildTemplate() (string, configtemplate.Config) { | |||
| cfg.AddParameter("pollingPeriod", configtemplate.TypeDurationNs, false) | |||
| cfg.AddParameter("pageSize", configtemplate.TypeDurationUnsignedInteger, false) | |||
|
|
|||
| return connectorName, cfg | |||
There was a problem hiding this comment.
Maybe do it on all connectors?
Signed-off-by: Lawrence Zawila <113581282+darkmatterpool@users.noreply.github.com>
Signed-off-by: Lawrence Zawila <113581282+darkmatterpool@users.noreply.github.com>
Signed-off-by: Lawrence Zawila <113581282+darkmatterpool@users.noreply.github.com>
gfyrag
reviewed
Dec 5, 2022
internal/app/api/stripe.go
Outdated
| connectorStore := integration.NewMongoDBConnectorStore(db) | ||
| var cfg stripeConnector.Config | ||
|
|
||
| err := connectorStore.ReadConfig(context.Background(), stripeConnector.Name, &cfg) |
gfyrag
reviewed
Dec 5, 2022
| } | ||
|
|
||
| params := &stripe.TransferParams{ | ||
| Amount: stripe.Int64(transferRequest.Amount), |
There was a problem hiding this comment.
Please, can you forward context on params?
Signed-off-by: Lawrence Zawila <113581282+darkmatterpool@users.noreply.github.com>
gfyrag
approved these changes
Dec 5, 2022
flemzord
added a commit
that referenced
this pull request
Sep 25, 2024
Co-authored-by: Geoffrey Ragot <geoffrey.ragot@gmail.com> Co-authored-by: Maxence Maireaux <maxence@maireaux.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lawrence Zawila 113581282+darkmatterpool@users.noreply.github.com