Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: print error log instead of crashing scheduler #77

Merged
merged 1 commit into from
Jan 2, 2023

Conversation

darkmatterpool
Copy link
Contributor

…onfig

Signed-off-by: Lawrence Zawila <113581282+darkmatterpool@users.noreply.github.com>
@darkmatterpool darkmatterpool self-assigned this Jan 2, 2023
@codecov
Copy link

codecov bot commented Jan 2, 2023

Codecov Report

Merging #77 (648557b) into main (2097a6f) will increase coverage by 0.13%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
+ Coverage   20.08%   20.21%   +0.13%     
==========================================
  Files         104      104              
  Lines        4417     4417              
==========================================
+ Hits          887      893       +6     
+ Misses       3437     3431       -6     
  Partials       93       93              
Impacted Files Coverage Δ
internal/app/task/scheduler.go 60.99% <0.00%> (ø)
...rnal/app/connectors/dummypay/task_generate_file.go 75.70% <0.00%> (+5.60%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@flemzord flemzord requested a review from gfyrag January 2, 2023 14:58
@flemzord flemzord merged commit 597dc59 into main Jan 2, 2023
@flemzord flemzord deleted the fix/scheduler-crash-on-bad-config branch January 2, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants