Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: secrets encryption #88

Merged
merged 5 commits into from
Feb 2, 2023
Merged

Feat: secrets encryption #88

merged 5 commits into from
Feb 2, 2023

Conversation

darkmatterpool
Copy link
Contributor

No description provided.

Signed-off-by: Lawrence Zawila <113581282+darkmatterpool@users.noreply.github.com>
Signed-off-by: Lawrence Zawila <113581282+darkmatterpool@users.noreply.github.com>
Signed-off-by: Lawrence Zawila <113581282+darkmatterpool@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Merging #88 (a0fd7f7) into main (e767e68) will decrease coverage by 0.32%.
The diff coverage is 2.58%.

@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
- Coverage   19.54%   19.22%   -0.32%     
==========================================
  Files         105      106       +1     
  Lines        4743     4832      +89     
==========================================
+ Hits          927      929       +2     
- Misses       3713     3798      +85     
- Partials      103      105       +2     
Impacted Files Coverage Δ
cmd/migrate.go 0.00% <0.00%> (ø)
cmd/root.go 0.00% <0.00%> (ø)
cmd/server.go 0.00% <0.00%> (ø)
internal/app/connectors/bankingcircle/config.go 0.00% <0.00%> (ø)
internal/app/connectors/currencycloud/config.go 0.00% <0.00%> (ø)
internal/app/connectors/modulr/config.go 0.00% <0.00%> (ø)
internal/app/connectors/stripe/config.go 0.00% <0.00%> (ø)
internal/app/connectors/wise/config.go 0.00% <0.00%> (ø)
internal/app/integration/manager.go 46.89% <0.00%> (ø)
internal/app/integration/storememory.go 63.15% <0.00%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@gfyrag gfyrag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Some tests on the storage parts would have been cool.

@darkmatterpool darkmatterpool merged commit 5dcc970 into main Feb 2, 2023
@darkmatterpool darkmatterpool deleted the feat/secrets-encryption branch February 2, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants