fix: pagination logic when using previous cursor #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch caused previous cursor to appear in API responses even if there was no previous data available. Signed-off-by: Lawrence Zawila <113581282+darkmatterpool@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #94 +/- ##
==========================================
- Coverage 19.22% 18.94% -0.29%
==========================================
Files 106 106
Lines 4832 4889 +57
==========================================
- Hits 929 926 -3
- Misses 3798 3857 +59
- Partials 105 106 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
gfyrag
previously approved these changes
Feb 2, 2023
antoinegelloz
previously approved these changes
Feb 2, 2023
Signed-off-by: Lawrence Zawila <113581282+darkmatterpool@users.noreply.github.com>
darkmatterpool
dismissed stale reviews from antoinegelloz and gfyrag
via
31ed732
Signed-off-by: Lawrence Zawila <113581282+darkmatterpool@users.noreply.github.com>
antoinegelloz
previously approved these changes
Feb 2, 2023
Signed-off-by: Lawrence Zawila <113581282+darkmatterpool@users.noreply.github.com>
antoinegelloz
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug caused the previous cursor to appear in API responses even if no last data was available.
Signed-off-by: Lawrence Zawila 113581282+darkmatterpool@users.noreply.github.com