Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: transfer initiation #96

Merged
merged 10 commits into from
Feb 3, 2023
Merged

feat: transfer initiation #96

merged 10 commits into from
Feb 3, 2023

Conversation

darkmatterpool
Copy link
Contributor

No description provided.

Signed-off-by: Lawrence Zawila <113581282+darkmatterpool@users.noreply.github.com>
…ting

Signed-off-by: Lawrence Zawila <113581282+darkmatterpool@users.noreply.github.com>
@@ -185,7 +185,7 @@ func uninstall[Config models.ConnectorConfigObject](connectorManager *integratio
func install[Config models.ConnectorConfigObject](connectorManager *integration.ConnectorManager[Config],
) http.HandlerFunc {
return func(w http.ResponseWriter, r *http.Request) {
installed, err := connectorManager.IsInstalled(context.Background())
installed, err := connectorManager.IsInstalled(context.TODO())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to use request context to be able to trace calls (sorry i should have said this on previous PR)

@@ -222,7 +222,7 @@ func install[Config models.ConnectorConfigObject](connectorManager *integration.
func reset[Config models.ConnectorConfigObject](connectorManager *integration.ConnectorManager[Config],
) http.HandlerFunc {
return func(w http.ResponseWriter, r *http.Request) {
installed, err := connectorManager.IsInstalled(context.Background())
installed, err := connectorManager.IsInstalled(context.TODO())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Merging #96 (7336120) into main (09953b5) will decrease coverage by 1.31%.
The diff coverage is 2.92%.

@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
- Coverage   18.94%   17.63%   -1.31%     
==========================================
  Files         106      112       +6     
  Lines        4889     5307     +418     
==========================================
+ Hits          926      936      +10     
- Misses       3857     4264     +407     
- Partials      106      107       +1     
Impacted Files Coverage Δ
internal/app/api/connector.go 0.00% <0.00%> (ø)
internal/app/api/connectormodule.go 0.00% <0.00%> (ø)
internal/app/api/router.go 0.00% <0.00%> (ø)
internal/app/connectors/currencycloud/connector.go 0.00% <0.00%> (ø)
internal/app/connectors/dummypay/connector.go 52.38% <0.00%> (-4.03%) ⬇️
internal/app/connectors/modulr/connector.go 0.00% <0.00%> (ø)
internal/app/connectors/stripe/connector.go 0.00% <0.00%> (ø)
internal/app/connectors/stripe/task_transfer.go 0.00% <0.00%> (ø)
internal/app/connectors/stripe/translate.go 0.00% <0.00%> (ø)
internal/app/connectors/wise/client.go 0.00% <0.00%> (ø)
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@@ -73,6 +74,8 @@ func connectorRouter[Config models.ConnectorConfigObject](
addRoute(r, provider, "/reset", http.MethodPost, reset(manager))
addRoute(r, provider, "/tasks", http.MethodGet, listTasks(manager))
addRoute(r, provider, "/tasks/{taskID}", http.MethodGet, readTask(manager))
addRoute(r, provider, "/transfer", http.MethodPost, initiateTransfer(manager))
Copy link
Contributor

@gfyrag gfyrag Feb 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe merge both.
Either pluralize or not, but we need to make a choice.

Signed-off-by: Lawrence Zawila <113581282+darkmatterpool@users.noreply.github.com>
Signed-off-by: Lawrence Zawila <113581282+darkmatterpool@users.noreply.github.com>
Signed-off-by: Lawrence Zawila <113581282+darkmatterpool@users.noreply.github.com>
Signed-off-by: Lawrence Zawila <113581282+darkmatterpool@users.noreply.github.com>
@darkmatterpool darkmatterpool merged commit 5e3b644 into main Feb 3, 2023
@darkmatterpool darkmatterpool deleted the feat/transfer-initiation branch February 3, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants