feat: transfer initiation #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lawrence Zawila <113581282+darkmatterpool@users.noreply.github.com>
…ting Signed-off-by: Lawrence Zawila <113581282+darkmatterpool@users.noreply.github.com>
gfyrag
reviewed
Feb 2, 2023
internal/app/api/connector.go
Outdated
| @@ -185,7 +185,7 @@ func uninstall[Config models.ConnectorConfigObject](connectorManager *integratio | |||
| func install[Config models.ConnectorConfigObject](connectorManager *integration.ConnectorManager[Config], | |||
| ) http.HandlerFunc { | |||
| return func(w http.ResponseWriter, r *http.Request) { | |||
| installed, err := connectorManager.IsInstalled(context.Background()) | |||
| installed, err := connectorManager.IsInstalled(context.TODO()) | |||
There was a problem hiding this comment.
Better to use request context to be able to trace calls (sorry i should have said this on previous PR)
gfyrag
reviewed
Feb 2, 2023
internal/app/api/connector.go
Outdated
| @@ -222,7 +222,7 @@ func install[Config models.ConnectorConfigObject](connectorManager *integration. | |||
| func reset[Config models.ConnectorConfigObject](connectorManager *integration.ConnectorManager[Config], | |||
| ) http.HandlerFunc { | |||
| return func(w http.ResponseWriter, r *http.Request) { | |||
| installed, err := connectorManager.IsInstalled(context.Background()) | |||
| installed, err := connectorManager.IsInstalled(context.TODO()) | |||
Codecov Report
@@ Coverage Diff @@
## main #96 +/- ##
==========================================
- Coverage 18.94% 17.63% -1.31%
==========================================
Files 106 112 +6
Lines 4889 5307 +418
==========================================
+ Hits 926 936 +10
- Misses 3857 4264 +407
- Partials 106 107 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
gfyrag
reviewed
Feb 2, 2023
internal/app/api/router.go
Outdated
| @@ -73,6 +74,8 @@ func connectorRouter[Config models.ConnectorConfigObject]( | |||
| addRoute(r, provider, "/reset", http.MethodPost, reset(manager)) | |||
| addRoute(r, provider, "/tasks", http.MethodGet, listTasks(manager)) | |||
| addRoute(r, provider, "/tasks/{taskID}", http.MethodGet, readTask(manager)) | |||
| addRoute(r, provider, "/transfer", http.MethodPost, initiateTransfer(manager)) | |||
Signed-off-by: Lawrence Zawila <113581282+darkmatterpool@users.noreply.github.com>
# Conflicts: # swagger.yml
Signed-off-by: Lawrence Zawila <113581282+darkmatterpool@users.noreply.github.com>
Signed-off-by: Lawrence Zawila <113581282+darkmatterpool@users.noreply.github.com>
Signed-off-by: Lawrence Zawila <113581282+darkmatterpool@users.noreply.github.com>
gfyrag
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.