fix(react-intl): use indexOf instead of includes

formatjs · Sep 27, 2021 · aed19a2 · aed19a2
1 parent 245301f
commit aed19a2
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/packages/react-intl/examples/BUILD b/packages/react-intl/examples/BUILD
@@ -33,8 +33,8 @@ ts_project(
     declaration_map = True,
     extends = "//:tsconfig.json",
     out_dir = "lib",
+    resolve_json_module = True,
     tsconfig = "//:tsconfig.esm.json",
-    resolve_json_module=True,
     deps = SRC_DEPS,
 )
 

diff --git a/packages/react-intl/index.ts b/packages/react-intl/index.ts
@@ -73,6 +73,7 @@ export const FormattedTime: React.FC<
       value: string | number | Date | undefined
     }
 > = createFormattedComponent('formatTime')
+// @ts-ignore issue w/ TS Intl types
 export const FormattedNumber: React.FC<
   NumberFormatOptions &
     CustomFormatConfig & {

diff --git a/packages/react-intl/src/components/relative.tsx b/packages/react-intl/src/components/relative.tsx
@@ -78,7 +78,7 @@ const INCREMENTABLE_UNITS: RelativeTimeFormatSingularUnit[] = [
 function canIncrement(
   unit: RelativeTimeFormatSingularUnit = 'second'
 ): boolean {
-  return INCREMENTABLE_UNITS.includes(unit)
+  return INCREMENTABLE_UNITS.indexOf(unit) > -1
 }
 
 const SimpleFormattedRelativeTime: React.FC<