Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite details feature using view binding #100

Closed
ikarenkov opened this issue Jun 26, 2021 · 0 comments · Fixed by #120
Closed

Rewrite details feature using view binding #100

ikarenkov opened this issue Jun 26, 2021 · 0 comments · Fixed by #120

Comments

@ikarenkov
Copy link
Collaborator

Rewrite details feature using view binding and keep only api and impl modules to show example of using #98
grine4ka pushed a commit that referenced this issue May 3, 2023
Rewrite details feature using view binding
deec3b0 
- Transfer databinding to viewbinding module
- Move ICharacterDetailViewModel and ICharacterDetailViewState to api module, cause it is API.
- Remove LiveData from API of ICharacterDetailViewState (debatable)
- Add ImageViewExtensions.kt file to provide extension to loadImage by url. Copy of databinding-adapter method

Closes #100
@grine4ka grine4ka mentioned this issue May 3, 2023
Merged
michaem pushed a commit that referenced this issue May 3, 2023
Rewrite details feature using view binding (#120)
4182e87 
- Transfer databinding to viewbinding module
- Move ICharacterDetailViewModel and ICharacterDetailViewState to api module, cause it is API.
- Remove LiveData from API of ICharacterDetailViewState (debatable)
- Add ImageViewExtensions.kt file to provide extension to loadImage by url. Copy of databinding-adapter method

Closes #100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rewrite details feature using view binding formatools/forma
1 participant
@ikarenkov