Fix tools.forma.includer plugin behavior
#128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Skip including nested projects - Consider only dirs with `build.gradle(.kts)` files as subprojects - Extend `IncluderPluginFunctionalTest` to cover problematic use cases
- Allowed to disable arbitrary build file names - Allowed to specify additional folder names to ignore - Do not allow to configure the project if a module with more than one build file is encountered - Covered all use cases of the plugin with tests - Added documentation to the README
|
Looks great! One concern from my side, using
includer {
excludeFolders("scripts", "tmp")
arbitraryBuildScriptNames = true
} |
- Create IncluderExtension and Dsl function `includer` for it - Add docs for IncluderExtension properties - Disable arbitraryBuildScriptNames by default - Covered all use cases of the plugin with tests - Update documentation in the README
|
@stepango, good point 👍 I fixed it. Now we can use type-safe |
stepango
approved these changes
Jul 8, 2023
grine4ka
reviewed
Jul 25, 2023
| @@ -58,7 +58,7 @@ dependencyResolutionManagement { | |||
| addPlugin("tools.forma.demo:dependencies", "0.0.1") | |||
| addPlugin( | |||
| "com.google.devtools.ksp", | |||
| "1.8.10-1.0.9", | |||
| "$embeddedKotlinVersion-1.0.9", | |||
There was a problem hiding this comment.
I don't think it would work. For example, after updating to gradle-8.2 embedded kotlin version would be 1.8.20, but there is NO ksp version 1.8.20-1.0.9: https://github.com/google/ksp/releases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some problems of the Includer plugin that prevent its integration with our project:
Current behavior: nested projects with
settings.gradle(.kts)are not added, but their subprojects are added.New behavior: nested projects with
settings.gradle(.kts)and their subprojects are completely skipped.tools.forma.includer.arbitraryBuildFileNames. For those cases when we want the plugin to include only modules withbuild.gradle(.kts)files.tools.forma.includer.ignoredFolders.IncluderPluginFunctionalTestto cover all plugin use cases.