FIO-8727: fix panel component not showing label in data grid #114
+6
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-8727
Description
What changed?
Changed the if condition for panels showing labels from ctx.component.hideLabel to ctx.label.hidden
Why have you chosen this solution?
ctx.label.hidden has additional checks upstream to determine if a label is hidden or not. We need these checks so that "Show Label in DataGrid" works as expected
Breaking Changes / Backwards Compatibility
N/A
Dependencies
N/A
How has this PR been tested?
Wrote a test in formio.js formio/formio.js#5937
Checklist: