Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO 8552: add modern linting, formatting, precommit hooks #5941

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

brendanbond
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-8552

Description

What changed?

  • Added modern linting and formatting (via eslint and prettier)
  • Fixed linter errors throughout the codebase
  • Formatted the codebase
  • Added the list-staged pre-commit hook as recommended by prettier

Breaking Changes / Backwards Compatibility

n/a

Dependencies

n/a

How has this PR been tested?

n/a

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@brendanbond brendanbond marked this pull request as draft December 6, 2024 20:53
@brendanbond
Copy link
Contributor Author

making this a draft so @edwinanciani can fix the number component test that is failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant