Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for julia 1.8 #9

Merged
merged 7 commits into from
Jun 1, 2022
Merged

Updates for julia 1.8 #9

merged 7 commits into from
Jun 1, 2022

Conversation

lassepe
Copy link
Collaborator

@lassepe lassepe commented Jun 1, 2022

In preparation to make this package work with Julia 1.8 I made a bunch of changes

  • Remove the Manifest.toml as it is version specific (and prevents the CI from testing with the latest versions)
  • Explicitly convert the sum result to Cint since we previously accidentally relied on a bug in sum which has now been fixed

Related but not strictly necessary for 1.8 compatibility:

  • Updated the CI.yml to always test on the latest stable version (rather than pinning to 1.7.0-rc1) and the nightly build (to catch issues like this earlier)
  • Made Test a test dependency rather than a primary dependency of the package
  • Removed the caching step from the CI because it's not necessary for the lightweight dependencies that we have and I have observed issues in the past (for another package) where this kind of caching caused trouble when the CI was updated to a new Julia version

I have also bumped the version to 0.3.6 which we should tag once this PR has been merged.

lassepe added 5 commits June 1, 2022 13:30
The promotion rules in Julia 1.8.0-rc1 have changed and sum(Cint.(1, 2)) now yields an Int64.
Therefore, we have to explicitly cast the result to Cint here.
@lassepe lassepe changed the title [WIP] Updates for julia 1.8 Updates for julia 1.8 Jun 1, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2022

Codecov Report

Merging #9 (98719ba) into main (b264ee2) will increase coverage by 0.17%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
+ Coverage   98.49%   98.66%   +0.17%     
==========================================
  Files           1        1              
  Lines         199      225      +26     
==========================================
+ Hits          196      222      +26     
  Misses          3        3              
Flag Coverage Δ
unittests 98.66% <100.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/nash.jl 98.66% <100.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b264ee2...98719ba. Read the comment docs.

@forrestlaine forrestlaine merged commit 2d434a5 into main Jun 1, 2022
@lassepe lassepe deleted the fix/udpates_for_julia_1.8 branch June 1, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants