lnd: add option for configuring REST port #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add this fixup? |
nixbitcoin
reviewed
Jun 2, 2020
modules/lnd.nix
Outdated
| @@ -45,10 +46,15 @@ in { | |||
| description = "The data directory for LND."; | |||
| }; | |||
| rpcPort = mkOption { | |||
| type = types.ints.u16; | |||
There was a problem hiding this comment.
Is it necessary to change this? From the NixOS module: "types.port: A port number. This type is an alias to types.ints.u16."
If so, should we change all occurrences of types.ints.u16 -> types.port
There was a problem hiding this comment.
Yes, we should change them separately: #190
|
Concept ACK |
mmilata
force-pushed
the
lnd-configurable-rest-port
branch
from
255dc90 to
34f3999
Compare
|
Updated, PTAL. |
mmilata
force-pushed
the
lnd-configurable-rest-port
branch
from
34f3999 to
03a627a
Compare
nixbitcoin
approved these changes
Jun 7, 2020
There was a problem hiding this comment.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
ACK 03a627a06f62446a388ce76dc8ea1305fcb22317
1. Ran ./run-tests.sh locally
2. Deployed to NixOS nix-bitcoin node and confirmed working with
different `restPort` values
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEV3o0Un8+KoXoD+Fk3RH5rVMIs7oFAl7c2yYACgkQ3RH5rVMI
s7pmVRAAnyTQXrVeu823zpie50CYmpzRSwFH2xIrikAYX8jjXHRbJyxEIHp5Dkx0
268+9QNZJP/xBp1D8DEy4/ODShahA5SJB7c0wnP8EkSrx4iDiDtt4rIxC/rcptfS
R3frGIu0mzWcpNqZq5HAVc3eU9OELaOdgU0MAJZBym0jJNFu8M5kmjAtM88UcARm
J2iNHjNNaLOeZgBlx6ZzkY2x0aFH12gOsbWC65yGK3RnYf0jhlrw96onfaigbis1
lpqcM8E9y+/+DcY+kS7EUYVdTAh01mMfsZ+ILLW/FCyHUTXAe0e3kyNbNMc8Kw/O
7YeXIhRCK4G64fSCndrSUepsxRLh0rlbrlr5rfdsVdbKKAkLqXMprVCiQTNxOoLF
GTSVm48MRsOSSWphCug5roMNJ/HhXW/A9Z4mW90NdcsIT8tsmyYmcRteEnnRZeQR
Q10uhRZ6UMERLzr2/SR89jrBV75qIVcLWaKg5vWWq5Z0YIqj1v7L2a+Gsgcnr54d
++RHlHpOlLI5DLS6M2bNpllM1+hdlhdMBah/fo3S9Zvzm/MIE+dvkzmPMUM0p4Qx
0CFbqWBVUZekbORTFqW66gocBatpQ+npdFJai5ub9NIMJIj/Gy2WVqIdOLuxJcVr
emf9QxPeoTcnAXgKZt180wwa7O1TcKTNsls9jeehqanQlXJQA3s=
=rv1H
-----END PGP SIGNATURE-----
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've got a slightly contrived setup where I'm running nix-bitcoin in a container that shares network ports with another container which also uses 8080 and it's harder to change than in lnd ...