-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix systemd leak #213
Fix systemd leak #213
Conversation
Mitigates a security issue that allows unprivileged users to read other unprivileged user's processes' credentials from CGroup using `systemctl status`.
be3dfcd
to
6a8e29e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 6a8e29e
What exactly is the security issue here? |
|
The |
Doesn't work on my machine ("file not found"). It's prevented by |
And yeah, that'd be bad and should be fixed upstream as well. |
Ah, I missed that This is indeed a systemd bug, great job catching this, @nixbitcoin! This PR still has some critical issues, which are fixed here. |
Bug filed @ systemd/systemd#16825 |
Bug filed @ ElementsProject/lightning#3984 |
Mitigates a security issue that allows unprivileged users to read other unprivileged user's processes' credentials from CGroup using
systemctl status
. Also adds tests to make sure this issue doesn't reoccur.