-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add module 'versioning' #247
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
{ config, pkgs, lib, ... }: | ||
|
||
with lib; | ||
let | ||
version = config.nix-bitcoin.configVersion; | ||
|
||
# Sorted by increasing version numbers | ||
changes = [ | ||
# None yet | ||
# { | ||
# version = "0.1"; | ||
# condition = config.services.foo.enabled; | ||
# message = '' | ||
# demo message | ||
# ''; | ||
# } | ||
]; | ||
|
||
incompatibleChanges = optionals | ||
(version != null && versionOlder lastChange) | ||
(builtins.filter (change: versionOlder change && (change.condition or true)) changes); | ||
|
||
errorMsg = '' | ||
|
||
This version of nix-bitcoin contains the following changes | ||
that are incompatible with your config (version ${version}): | ||
|
||
${concatMapStringsSep "\n" (change: '' | ||
- ${change.message}(This change was introduced in version ${change.version}) | ||
'') incompatibleChanges} | ||
After addressing the above changes, set nix-bitcoin.configVersion = "${lastChange.version}"; | ||
in your nix-bitcoin configuration. | ||
''; | ||
|
||
versionOlder = change: (builtins.compareVersions change.version version) > 0; | ||
lastChange = builtins.elemAt changes (builtins.length changes - 1); | ||
in | ||
{ | ||
options = { | ||
nix-bitcoin.configVersion = mkOption { | ||
type = with types; nullOr str; | ||
default = null; | ||
description = '' | ||
Set this option to the nix-bitcoin release version that your config is | ||
compatible with. | ||
|
||
When upgrading to a backwards-incompatible release, nix-bitcoin will throw an | ||
error during evaluation and provide hints for migrating your config to the | ||
new release. | ||
''; | ||
}; | ||
}; | ||
|
||
## No config because there are no backwards incompatible releases yet | ||
# config = { | ||
# # Force evaluation. An actual option value is never assigned | ||
# system.extraDependencies = optional (builtins.length incompatibleChanges > 0) (builtins.throw errorMsg); | ||
# }; | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this "or true" do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It returns
true
if the change has nocondition
attribute.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Hadn't noticed that construction before.