Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

joinmarket: 0.8.2 -> 0.8.3 #368

Merged
merged 4 commits into from
Aug 10, 2021
Merged

Conversation

nixbitcoin
Copy link
Member

Update JoinMarket. See commit message for notes.

@erikarvstedt
Copy link
Collaborator

Sorry, I've somehow missed this PR.

Fixed branch + fixups.

  • Split topics into separate commits to ease reviewing
  • Add some fixups

nixbitcoin and others added 4 commits August 10, 2021 10:12
Includes
- coincurve: 13.0.0 -> 15.0.0
- Update Darkscience Tor onion address
Don't copy bitcoin-rpcpassword-privileged as root, instead run service
with group "bitcoin".
Same effect, less complexity. Note, PoLP still obeyed for joinmarket-ob-watcher.
Starting with 0.21.0, bitcoin no longer automatically creates and loads
a default wallet.
This was being ignored because of a JoinMarket issue [1] in CI builds prior
to this version. Now a watch-only Bitcoin Core wallet is created in ExecStartPost.

[1] JoinMarket-Org/joinmarket-clientserver#812
@nixbitcoin
Copy link
Member Author

Squashed with three changes

  • Rebased on master
  • Updated darkscience Tor onion address also in joinmarket-ob-watcher
  • Targeted v0.0.49 for release

Copy link
Collaborator

@erikarvstedt erikarvstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 881a3aa

@jonasnick jonasnick merged commit fb456f8 into fort-nix:master Aug 10, 2021
@nixbitcoin nixbitcoin deleted the joinmarket-0.8.3 branch December 30, 2021 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants