Update nixpkgs-unstable, fix whitelisting local services #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikarvstedt
force-pushed
the
update-nixpkgs
branch
from
a0d3041 to
a3356cf
Compare
This removes the module-level dependency from onion-services to bitcoind. Due to the `or false` fallback, there's no dependency added in the reverse direction. In particular, this allows us to not add a dependency on liquidd in the following commit.
erikarvstedt
force-pushed
the
update-nixpkgs
branch
from
a3356cf to
9acd469
Compare
|
Through manual testing I figured out that we need to add |
Switch back from nixpkgs master to unstable. Pkg updates: btcpayserver: 1.2.3 -> 1.2.4 electrs: 0.9.0 -> 0.9.1 elementsd: 0.18.1.12 -> 0.21.0 lightning-pool: 0.5.0-alpha -> 0.5.1-alpha nbxplorer: 2.2.5 -> 2.2.11 - liquidd: add `onionPort` like in bitcoind - tests/electrs: remove KillSignal workaround
erikarvstedt
force-pushed
the
update-nixpkgs
branch
from
9acd469 to
be0e9e4
Compare
erikarvstedt
changed the title
|
@nixbitcoin, I've implemented your suggestion via |
This allows whitelisting local services without implicitly whitelisting all inbound onion connections, which would happen when setting bitcoind/liquidd option `whitelist=localhost`. Used by electrs and nbxplorer, which requires the unsafe `mempool` permission.
erikarvstedt
force-pushed
the
update-nixpkgs
branch
from
be0e9e4 to
1da23cd
Compare
- README: add matrix room - examples/configuration.nix: explain why bitcoind is enabled by default - btcpayserver: group lnd service settings - clightning: Use public onion port only when the onion service is public This allows users to enable the onion service while announcing a non-onion public address. - netns-isolation: move `readOnly` attr to the top - tests: use mkDefault to allow for easier overriding - tests/btcpayserver: test web server response
erikarvstedt
force-pushed
the
update-nixpkgs
branch
from
53cfca9 to
aada35f
Compare
jonasnick
approved these changes
Oct 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.