Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RTL #484

Merged
merged 4 commits into from
May 25, 2022
Merged

Update RTL #484

merged 4 commits into from
May 25, 2022

Conversation

erikarvstedt
Copy link
Collaborator

No description provided.

@nixbitcoin
Copy link
Member

nixbitcoin commented May 15, 2022 •
edited
Loading

Don't forget to update services.rtl.nodes.clightning, services.rtl.loop, and services.rtl.nodes.lnd in configuration.nix, as well as documenting the changes in versioning.nix.

Otherwise the changes look good!

@erikarvstedt
rtl: change nodes options
ff228a6 
- Move option `rtl.nodes.{lnd,clightning}` -> `rtl.nodes.{lnd,clightning}.enable`
  This is required by the next commit.

- Move option `rtl.loop` -> `rtl.nodes.lnd.loop`

- Only enable loop when `nodes.lnd` is enabled
@erikarvstedt
rtl: add option extraConfig for nodes
3755b3e 
Also define rtl config as a Nix attrset that is converted to JSON
@erikarvstedt
Copy link
Collaborator Author

erikarvstedt commented May 15, 2022 •
edited
Loading

Thanks! I've updated configuration.nix.

versioning.nix (or, more specifically, obsolete-options.nix) only works for backwards-compatible option changes, but this is a breaking change: We're converting a former option (nodes.lnd) into a option namespace (containing nodes.lnd.enable).
We have to mention this option change in the release notes instead.

When we switch to flake-based system configs, it will be easy to implement a versioning mechanism that works for all kinds of updates.

nixbitcoin
nixbitcoin approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@nixbitcoin nixbitcoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

ACK 3755b3ebea57e0cadd941d39e40002186159e769
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEiDOlIkszv4ojhh+OtgROy6La5dAFAmKOHvcACgkQtgROy6La
5dDQpg//V23OUjHb9ACn86EnxO3KR9Yr7pP+R1qIDkwVhk6i/MtqJuyOM9zUTR3D
l7rwqjSYzuTuCoZUdx8C6GWXB2zjGmSCpgl6Jfb9IE0CGZ+2qKsNbhrBEaHJnHwi
mFWiSlLfNc2n61KV6kaJC3iRQzh+Rubv1zTaRG1RvFYUFpXrQcu5nAjYTcnS18wi
4e+ptE03zXQQ6k5SBxsNLYSsiqp5K5Z6pATTx2L0SebZQ4ISogaAH86ObpMtdiQt
8AmwqW/eQTQl2yj7xPGWtoQn3+tAGOm/M8ZAPKIN5Taz8qqofentTfF0Ki39JJNl
lzuVcnqsGzGG0umbQIKosppP7DuN5DcIzq9bsVBEXZWAdTQ+SME0ViubGGi36GnO
k3h6xrfwgDKMYr7dy8EQnoTUt59GzFzqxBomTNddHJQAKyfMBjQ/lQD6I7ktopD2
mpIc3f0MoOuo2n0Oh0/PO4ZiiGSlmiCmGarzbCQcQdDSP4S6NlpznCi9+nzYUDyE
pKGkciZObCw1+7/fltMe5yOdmYnA+CfxgxLEMM0d7kgNBlQbYGr0rDjip97EKiAv
KcxJmwPDKahFwy5GrJRoV2XkRm2vObULP/YonzBusgBiV7o/R8OXnOeoWRPN7mht
dUexlfdIXHByi3ExI0UuYC2i4pUYtQ7BcXjnKPjm+bp0o9oiYDs=
=Imr0
-----END PGP SIGNATURE-----

@jonasnick jonasnick merged commit ebaa9a3 into fort-nix:master May 25, 2022
nixbitcoin added a commit to nixbitcoin/nixbitcoin.org that referenced this pull request May 27, 2022
@nixbitcoin
temp: update rtl for fort-nix/nix-bitcoin#484
91e519e 
Necessary while merged in master but not released yet
erikarvstedt pushed a commit to erikarvstedt/nixbitcoin.org that referenced this pull request Jun 30, 2022
@nixbitcoin @erikarvstedt
temp: update rtl for fort-nix/nix-bitcoin#484
080d40a 
Necessary while merged in master but not released yet
erikarvstedt pushed a commit to erikarvstedt/nixbitcoin.org that referenced this pull request Jul 5, 2022
@nixbitcoin @erikarvstedt
temp: update rtl for fort-nix/nix-bitcoin#484
e907373 
Necessary while merged in master but not released yet
nixbitcoin added a commit to fort-nix/nixbitcoin.org that referenced this pull request Jul 8, 2022
@nixbitcoin
Merge #42: Deploy to new server
7cdec7c 
6975252 postgresql: increase `shared_buffers` size (Erik Arvstedt)
19096ab maintenance: add section 'Securely erase hard disks' (Erik Arvstedt)
958e7a5 maintenance: add postgresql schema update guide (Erik Arvstedt)
8969ed9 add maintenance.sh (Erik Arvstedt)
4fdd0b1 add zfs autoscrub (Erik Arvstedt)
abb4434 secrets: add ssh-key-seedhost (Erik Arvstedt)
eb53d74 secrets: add btcpayserver internal wallet seeds (nixbitcoin)
651991f btcpayserver: correct link to new store (nixbitcoin)
5d36eeb joinmarket: generate new wallet and use rpcWalletFile (nixbitcoin)
0ff0628 disable hardened kernel profile (Erik Arvstedt)
4a74ed2 add deployment guide (Erik Arvstedt)
0b83384 hardware.nix: adapt to new server (Erik Arvstedt)
986503b use a zfs mirror for storage (Erik Arvstedt)
187527a add sudo -> doas shell alias (Erik Arvstedt)
013aca5 base: add some sensible defaults (Erik Arvstedt)
c45399d base: disable networking.usePredictableInterfaceNames to simplify deployments (Erik Arvstedt)
69a75f0 secrets: add SSH host key (Erik Arvstedt)
be86939 add secrets/add-secret helper script (Erik Arvstedt)
da40a21 base: add root.hashedPassword (Erik Arvstedt)
f1ef36b extract base config (Erik Arvstedt)
c490db1 use current fulcrum version (Erik Arvstedt)
e907373 temp: update rtl for fort-nix/nix-bitcoin#484 (nixbitcoin)
18bbe13 website: add mempool.nixbitcoin.org (nixbitcoin)

Pull request description:

Top commit has no ACKs.

Tree-SHA512: 251ee0b13274404b24e10f8ccb4bfaff4b069f488a53be0fe007c2ab4a9b23522c8a871a9f9a3c2cd521a8d83321db67eb8f87e53e22a3ec22ef47638614f920
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nixbitcoin nixbitcoin nixbitcoin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erikarvstedt @nixbitcoin @jonasnick