Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtl: 0.14.1 -> 0.15.4, add clightning.plugins.clnrest #688

Merged
merged 6 commits into from
Nov 27, 2024

Conversation

erikarvstedt
Copy link
Collaborator

@erikarvstedt erikarvstedt commented Apr 5, 2024

This fixes lndconnect for recent versions of Zeus

Todo:

  • Manually test RTL
  • Manually run test lndconnect-wg
  • Deploy on nixbitcoin.org
  • Deploy locally and investigate Too many files gevent error (possible upstream bug)

@suorcd
Copy link

suorcd commented Jul 13, 2024

There have been 2 point releases since this ticket has been put on hold.

@kmajs
Copy link

kmajs commented Sep 10, 2024

Also, Zeus Wallet 0.9.0 was released a few weeks ago with support for clnrest. Do you think this draft could be merged for the next release?

@erikarvstedt erikarvstedt changed the title rtl: 0.14.1 -> 0.15.0, add clightning.plugins.clnrest rtl: 0.14.1 -> 0.15.2, add clightning.plugins.clnrest Oct 9, 2024
@erikarvstedt erikarvstedt force-pushed the clnrest branch 2 times, most recently from fcf676b to b32dbad Compare October 10, 2024 10:14
@erikarvstedt erikarvstedt marked this pull request as ready for review October 14, 2024 10:48
Copy link
Member

@jonasnick jonasnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK

modules/clightning-plugins/clnrest.nix Outdated Show resolved Hide resolved
modules/rtl.nix Outdated Show resolved Hide resolved
@erikarvstedt erikarvstedt changed the title rtl: 0.14.1 -> 0.15.2, add clightning.plugins.clnrest rtl: 0.14.1 -> 0.15.4, add clightning.plugins.clnrest Nov 27, 2024
Using `clightning-rest` is no longer supported by rtl.
`clightning-rest` will be deprecated soon.
Copy link
Member

@jonasnick jonasnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @erikarvstedt!

ACK daa3bfb

@jonasnick jonasnick merged commit 64fb83b into fort-nix:master Nov 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants