Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update nixpkgs #711

Merged
merged 1 commit into from
Jul 3, 2024
Merged

update nixpkgs #711

merged 1 commit into from
Jul 3, 2024

Conversation

jonasnick
Copy link
Member

bitcoin: 27.0 -> 27.1
bitcoind: 27.0 -> 27.1
clightning: 24.02.2 -> 24.05
fulcrum: 1.10.0 -> 1.11.0
lnd: 0.17.5-beta -> 0.18.0-beta

The trustedcoin test scenario currently fails with error:

vm-test-run-nix-bitcoin-trustedcoin> machine # [    8.757348] lightningd[1084]: Wrong network! Our Bitcoin backend is running on '', but we expect 'regtest'.

This appears to be an issue in trustedcoin.
CC @seberm

@seberm
Copy link
Contributor

seberm commented Jul 2, 2024

Hello @jonasnick ,
Is the trustedcoin scenario still failing? I noticed that all checks are passing in this PR. Could you guide me on how to reproduce the issue?

I tried running the tests locally, but I couldn't reproduce the problem:

git checkout update-nixpkgs63
cd tests
./run-tests.sh -s "trustedcoin"

@erikarvstedt
Copy link
Collaborator

Test trustedcoin works for me, too.

Here's a fix for the failing examples (covered by run-tests.sh all which includes run-tests.sh examples).

bitcoin: 27.0 -> 27.1
bitcoind: 27.0 -> 27.1
clightning: 24.02.2 -> 24.05
fulcrum: 1.10.0 -> 1.11.0
lnd: 0.17.5-beta -> 0.18.0-beta

Co-authored-by: Erik Arvstedt <erik.arvstedt@gmail.com>
@jonasnick jonasnick marked this pull request as ready for review July 3, 2024 06:14
@jonasnick
Copy link
Member Author

Hm, I can't reproduce the trustedcoin issue I had seen either. Sorry.

Thanks Erik for the fixups, for some reason I had only run ./run-tests.sh buildable.

Copy link
Collaborator

@erikarvstedt erikarvstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b26cea0

@jonasnick jonasnick merged commit 652b67e into fort-nix:master Jul 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants