-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Nixos 24.05 #718
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasnick
reviewed
Jul 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @erikarvstedt !
cccc95f looks good so far.
6699090
to
2b84179
Compare
Requirements checking has been re-enabled in nixos 24.05.
- coincurve has been bumped to v20 on pyln-proto master without further code changes, so using v19 is fine - the breaking changes in cryptography 42 don't affect pyln-proto https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst
2b84179
to
ffedd2c
Compare
4cb51ca
to
c776316
Compare
c776316
to
c0da27f
Compare
Fix warning: ``` bitcoind.service is ordered after 'network-online.target' but doesn't depend on it ```
Sandbox is off by default in the `docker-nixpkgs` image.
Ensure that the file relative to the example scripts is called. Previously, the unqualified call would give precedence to source files in PATH. This could lead to the wrong file being called when dir `helper` (containing another file named `start-bash-session.sh`) was in PATH.
2e582c3
to
86e62c7
Compare
Now all `supportedSystems` from flake.nix are checked instead of only the native system of the `nix flake check` process.
86e62c7
to
2a9489e
Compare
jonasnick
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 2a9489e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo:
nixos-search/flake-info-sandboxed.sh
which fails in some Nixos 24.05 system environments.The
nixos-search
CI test works fine.start-bash-session.sh
bug.