Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Nixos 24.05 #718

Merged
merged 12 commits into from
Jul 22, 2024
Merged

Update to Nixos 24.05 #718

merged 12 commits into from
Jul 22, 2024

Conversation

erikarvstedt
Copy link
Collaborator

@erikarvstedt erikarvstedt commented Jul 15, 2024

Todo:

  • Deploy to https://nixbitcoin.org
  • Fix nixos-search/flake-info-sandboxed.sh which fails in some Nixos 24.05 system environments.
    The nixos-search CI test works fine.
  • Fix start-bash-session.sh bug.

Copy link
Member

@jonasnick jonasnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @erikarvstedt !
cccc95f looks good so far.

@erikarvstedt erikarvstedt force-pushed the nixos-24.05 branch 8 times, most recently from 6699090 to 2b84179 Compare July 18, 2024 18:47
Requirements checking has been re-enabled in nixos 24.05.
- coincurve has been bumped to v20 on pyln-proto master without further
  code changes, so using v19 is fine

- the breaking changes in cryptography 42 don't affect pyln-proto
  https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst
@erikarvstedt erikarvstedt marked this pull request as ready for review July 20, 2024 17:39
@erikarvstedt erikarvstedt force-pushed the nixos-24.05 branch 2 times, most recently from 4cb51ca to c776316 Compare July 20, 2024 20:38
Fix warning:
```
bitcoind.service is ordered after 'network-online.target' but doesn't depend on it
```
Sandbox is off by default in the `docker-nixpkgs` image.
Ensure that the file relative to the example scripts is called.
Previously, the unqualified call would give precedence to source files in
PATH. This could lead to the wrong file being called when dir
`helper` (containing another file named `start-bash-session.sh`) was in PATH.
@erikarvstedt erikarvstedt force-pushed the nixos-24.05 branch 2 times, most recently from 2e582c3 to 86e62c7 Compare July 20, 2024 20:46
Now all `supportedSystems` from flake.nix are checked instead of only
the native system of the `nix flake check` process.
Copy link
Member

@jonasnick jonasnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 2a9489e

@jonasnick jonasnick merged commit 1c6e35e into fort-nix:master Jul 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants